r73161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73160‎ | r73161 | r73162 >
Date:22:07, 16 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Integrated some jquery.ui customizations from UsabilityInitiative
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-down.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-off.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-over.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/close.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/titlebar-fade.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.dialog.css (modified) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.theme.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.dialog.css
@@ -11,3 +11,51 @@
1212 .ui-dialog .ui-dialog-buttonpane button { float: right; margin: .5em .4em .5em 0; cursor: pointer; padding: .2em .6em .3em .6em; line-height: 1.4em; width:auto; overflow:visible; }
1313 .ui-dialog .ui-resizable-se { width: 14px; height: 14px; right: 3px; bottom: 3px; }
1414 .ui-draggable .ui-dialog-titlebar { cursor: move; }
 15+/* Customizations */
 16+body .ui-dialog .ui-dialog-titlebar-close:hover {
 17+ text-decoration: none;
 18+}
 19+body .ui-dialog .ui-dialog-content .status-invalid input {
 20+ border: 2px solid red;
 21+ padding: 2px 1px;
 22+}
 23+body .ui-dialog .ui-dialog-titlebar {
 24+ padding: 0.9em 1.4em 0.6em !important;
 25+}
 26+body .ui-dialog .ui-dialog-buttonpane button {
 27+ -moz-border-radius: 4px;
 28+ -webkit-border-radius: 4px;
 29+ padding: 0.2em 0.6em 0.15em !important;
 30+ margin: 0.5em 0 0.5em 0.4em !important;
 31+ border: 1px solid #a6a6a6 !important;
 32+ background: #f2f2f2 url(images/button-off.png) repeat-x scroll 50% 100% !important;
 33+}
 34+body .ui-dialog .ui-dialog-buttonpane button:hover {
 35+ border-color: #6e7273;
 36+ background: #e1e1e1 url(images/button-over.png) repeat-x scroll 50% 100% !important;
 37+}
 38+body .ui-dialog .ui-dialog-buttonpane button:active,
 39+body .ui-dialog .ui-dialog-buttonpane button:focus {
 40+ border-color: #707271;
 41+ background: #bfbfbf url(images/button-down.png) repeat-x scroll 50% 100% !important;
 42+}
 43+body .ui-dialog .ui-dialog-buttonpane button.disabled {
 44+ color: #7f7f7f;
 45+ border-color: #cccccc;
 46+ background: #f2f2f2 url(images/button-disabled.png) repeat-x scroll 50% 100% !important;
 47+}
 48+/* Disables the annoying dashed border Firefox puts on active buttons */
 49+body .ui-dialog .ui-dialog-buttonpane button::-moz-focus-inner {
 50+ border: 0;
 51+}
 52+body .ui-dialog .ui-widget-header {
 53+ background: #f0f0f0 url(images/titlebar-fade.png) repeat-x scroll 50% 100% !important;
 54+}
 55+/* FIXME: Should just update the icon sprite if we're keeping this X */
 56+body .ui-dialog .ui-icon-closethick {
 57+ background: url(images/close-x.png) no-repeat 50% 50% !important;
 58+}
 59+body .ui-dialog .ui-dialog-buttonpane {
 60+ margin-top: 0 !important;
 61+ padding:0.3em 1.4em 0.5em 1.4em !important;
 62+}
Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.theme.css
@@ -13,7 +13,7 @@
1414 .ui-widget { font-family: sans-serif; font-size: 0.8em; }
1515 .ui-widget .ui-widget { font-size: 1em; }
1616 .ui-widget input, .ui-widget select, .ui-widget textarea, .ui-widget button { font-family: sans-serif; font-size: 1em; }
17 -.ui-widget-content { border: 1px solid #cccccc; background: #f2f5f7 url(images/ui-bg_highlight-hard_100_f2f5f7_1x100.png) 50% top repeat-x; color: #362b36; }
 17+.ui-widget-content { border: none; background: #f2f5f7 url(images/ui-bg_highlight-hard_100_f2f5f7_1x100.png) 50% top repeat-x; color: #362b36; }
1818 .ui-widget-content a { color: #362b36; }
1919 .ui-widget-header { border: 1px solid #aed0ea; line-height: 1em; background: #ffffff url(images/ui-bg_highlight-soft_100_ffffff_1x100.png) 50% 50% repeat-x; color: #222222; font-weight: bold; }
2020 .ui-widget-header a { color: #222222; }
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/titlebar-fade.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/titlebar-fade.png
___________________________________________________________________
Added: svn:mime-type
2121 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/close.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/close.png
___________________________________________________________________
Added: svn:mime-type
2222 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled.png
___________________________________________________________________
Added: svn:mime-type
2323 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down.png
___________________________________________________________________
Added: svn:mime-type
2424 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off.png
___________________________________________________________________
Added: svn:mime-type
2525 + image/png
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over.png
___________________________________________________________________
Added: svn:mime-type
2626 + image/png

Comments

#Comment by Krinkle (talk | contribs)   01:49, 22 January 2011

See also r73158

Status & tagging log