r73158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73157‎ | r73158 | r73159 >
Date:21:43, 16 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Moving some CSS to the vector jquery ui skin, rather than keeping them here as WikiEditor only customizations
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.css
@@ -14,58 +14,10 @@
1515 div.suggestions {
1616 z-index: 1099;
1717 }
18 -.wikiEditor-toolbar-dialog .ui-dialog-titlebar-close:hover {
19 - text-decoration: none;
20 -}
21 -.wikiEditor-toolbar-dialog .ui-dialog-content .status-invalid input {
22 - border: 2px solid red;
23 - padding: 2px 1px;
24 -}
25 -.wikiEditor-toolbar-dialog .ui-dialog-titlebar {
26 - padding: 0.9em 1.4em 0.6em !important;
27 -}
2818 .wikiEditor-toolbar-dialog table td {
2919 padding: 0 !important;
3020 }
31 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane button {
32 - -moz-border-radius: 4px;
33 - -webkit-border-radius: 4px;
34 - padding: 0.2em 0.6em 0.15em !important;
35 - margin: 0.5em 0 0.5em 0.4em !important;
36 - border: 1px solid #a6a6a6 !important;
37 - background: #f2f2f2 url(images/dialogs/button_off.png) repeat-x scroll 50% 100% !important;
38 -}
39 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane button:hover {
40 - border-color: #6e7273;
41 - background: #e1e1e1 url(images/dialogs/button_over.png) repeat-x scroll 50% 100% !important;
42 -}
43 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane button:active,
44 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane button:focus {
45 - border-color: #707271;
46 - background: #bfbfbf url(images/dialogs/button_down.png) repeat-x scroll 50% 100% !important;
47 -}
48 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane button.disabled {
49 - color: #7f7f7f;
50 - border-color: #cccccc;
51 - background: #f2f2f2 url(images/dialogs/button_disabled.png) repeat-x scroll 50% 100% !important;
52 -}
53 -/* Disables the annoying dashed border Firefox puts on active buttons */
54 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane button::-moz-focus-inner {
55 - border: 0;
56 -}
57 -.wikiEditor-toolbar-dialog .ui-widget-header {
58 - background: #f0f0f0 url(images/dialogs/titlebar_fade.png) repeat-x scroll 50% 100% !important;
59 -}
60 -/* FIXME: Should just update the icon sprite if we're keeping this X */
61 -.wikiEditor-toolbar-dialog .ui-icon-closethick {
62 - background: url(images/dialogs/close_x.png) no-repeat 50% 50% !important;
63 -}
64 -.wikiEditor-toolbar-dialog .ui-dialog-buttonpane {
65 - margin-top: 0 !important;
66 - padding:0.3em 1.4em 0.5em 1.4em !important;
67 -}
68 -
69 -.wikiEditor-toolbar-dialog .ui-dialog-content fieldset{
 21+.wikiEditor-toolbar-dialog .ui-dialog-content fieldset {
7022 border: none !important;
7123 margin: 0 !important;
7224 padding: 0 !important;
@@ -98,8 +50,4 @@
9951 }
10052 .wikieditor-toolbar-dialog-hint {
10153 color: #999999;
102 -}
103 -.wikiEditor-toolbar-dialog,
104 -.wikiEditor-toolbar-dialog .ui-widget-content {
105 - border: none !important;
10654 }
\ No newline at end of file

Comments

#Comment by Catrope (talk | contribs)   17:49, 1 October 2010

You removed these rules alright, but you didn't re-add them somewhere else although that does seem to be what you intended to do.

#Comment by Catrope (talk | contribs)   17:51, 1 October 2010

Looks like that happened in r73161, never mind.

Status & tagging log