r73064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73063‎ | r73064 | r73065 >
Date:14:37, 15 September 2010
Author:platonides
Status:resolved (Comments)
Tags:
Comment:
Absolutize require paths per r72858 CR.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/UploadFromUrlTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/api/ApiTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/api/ApiWatchTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/parser/MediaWikiParserTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/parser/ParserHelpers.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchDbTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/UploadFromUrlTest.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -require_once 'api/ApiSetup.php';
 4+require_once dirname( __FILE__ ) . '/api/ApiSetup.php';
55
66 class UploadFromUrlTest extends ApiTestSetup {
77
Index: trunk/phase3/maintenance/tests/phpunit/includes/parser/ParserHelpers.php
@@ -16,7 +16,7 @@
1717 if ( $result === NULL ) {
1818 $result = new PHPUnit_Framework_TestResult;
1919 }
20 -
 20+return $result;
2121 $backend = $this->suite->getBackend();
2222 $result->startTest( $this );
2323 PHPUnit_Util_Timer::start();
Index: trunk/phase3/maintenance/tests/phpunit/includes/parser/MediaWikiParserTest.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -require_once( 'ParserHelpers.php' );
 4+require_once( dirname( __FILE__ ) . '/ParserHelpers.php' );
55
66 class MediaWikiParserTestSuite extends PHPUnit_Framework_TestSuite {
77 private $count;
Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchDbTest.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -require_once( 'SearchEngineTest.php' );
 4+require_once( dirname( __FILE__ ) . '/SearchEngineTest.php' );
55
66 class SearchDbTest extends SearchEngineTest {
77 var $db;
Index: trunk/phase3/maintenance/tests/phpunit/includes/api/ApiTest.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -require_once( 'ApiSetup.php' );
 4+require_once( dirname( __FILE__ ) . '/ApiSetup.php' );
55
66 class MockApi extends ApiBase {
77 public function execute() { }
Index: trunk/phase3/maintenance/tests/phpunit/includes/api/ApiWatchTest.php
@@ -1,6 +1,6 @@
22 <?php
33
4 -require_once 'ApiSetup.php';
 4+require_once dirname( __FILE__ ) . '/ApiSetup.php';
55
66 class ApiWatchTest extends ApiTestSetup {
77

Follow-up revisions

RevisionCommit summaryAuthorDate
r73213Revert change on r73064 for this file....platonides14:27, 17 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72858Follow up r72566. Per CR r9132#c9132 these files were intended to explicitely...platonides13:42, 12 September 2010

Comments

#Comment by Tim Starling (talk | contribs)   02:13, 17 September 2010
-
+return $result;

Debugging code left in?

#Comment by Platonides (talk | contribs)   15:00, 17 September 2010

Removed in r73213

Status & tagging log