r73065 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73064‎ | r73065 | r73066 >
Date:15:15, 15 September 2010
Author:catrope
Status:deferred
Tags:
Comment:
PrefSwitch: Fix expanding ifyes/ifno text boxes, got broken by incomplete class rename
Modified paths:
  • /trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/PrefSwitch/PrefSwitch.js
@@ -42,7 +42,7 @@
4343 'survey-browser': browser, 'survey-os': os, 'survey-res-x': screen.width, 'survey-res-y': screen.height
4444 };
4545 }
46 - // Auto-hide/show "other" explaination fields for selects
 46+ // Auto-hide/show "other" explanation fields for selects
4747 $j( '.prefswitch-survey-other-select' ).parent().hide();
4848 $j( 'select.prefswitch-survey-need-other' ).change( function() {
4949 if ( $j(this).val() == 'other' ) {
@@ -55,7 +55,7 @@
5656 $j( '.prefswitch-survey-other-radios, .prefswitch-survey-other-checks' ).click( function() {
5757 $j(this).prev().prev().attr( 'checked', true );
5858 });
59 - // Auto-hide/show explaination fields for boolean
 59+ // Auto-hide/show explanation fields for boolean
6060 $j( '.prefswitch-survey-iftrue, .prefswitch-survey-iffalse' ).hide();
6161 $j( '.prefswitch-survey-true, .prefswitch-survey-false' ).change( function() {
6262 $ifTrueRow = $j( '#' + $j(this).attr( 'name' ) + '-iftrue-row' );
@@ -68,7 +68,7 @@
6969 $ifFalseRow.slideDown( 'fast' );
7070 }
7171 } );
72 - $j( '.prefswitch-survey-yes, .prefswitch-survey-no' ).change();
 72+ $j( '.prefswitch-survey-true, .prefswitch-survey-false' ).change();
7373 // Auto-detect browser, os and screen size
7474 var detected = detect();
7575 $j( '#prefswitch-survey-browser' ).val( detected['survey-browser'] );

Status & tagging log