r72832 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72831‎ | r72832 | r72833 >
Date:21:08, 11 September 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Using oimplode( ',', $to ) in wfDebug would only result in the same problem as the listed bug (object, object, object) that was being worked around

Bug linked tested on php 5.3.2 gives expected results. Can we optionally work around this now?
Modified paths:
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
——@@ -121,7 +121,7 @@
122122 $emails .= $t->toString() . ",";
123123 }
124124 $emails = rtrim( $emails, ',' );
125 - wfDebug( __METHOD__.': sending mail to ' . implode( ',', $to ) . "\n" );
 125+ wfDebug( __METHOD__.': sending mail to ' . $emails . "\n" );
126126 } else {
127127 wfDebug( __METHOD__.': sending mail to ' . implode( ',', array( $to->toString() ) ) . "\n" );
128128 }

Comments

#Comment by Reedy (talk | contribs)   21:13, 11 September 2010

Also, what's the point of putting something into an array to then just implode it? 

wfDebug( __METHOD__.': sending mail to ' . implode( ',', array( $to->toString() ) ) . "\n" );

Status & tagging log