r72623 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r72622‎ | r72623 | r72624 >
Date:01:15, 9 September 2010
Author:reedy
Status:resolved
Tags:
Comment:
Followup r72532, actually follow what the CR notes suggested, use limit fetching col, rather than unbounded count
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/api/ApiQueryArticleAssessment.php
——@@ -102,7 +102,7 @@
103103
104104 $res = $dbr->selectField(
105105 'revision',
106 - 'COUNT(*) AS norevs',
 106+ 'rev_id',
107107 array(
108108 'rev_page' => $params['pageid'],
109109 'rev_id > ' . $ratings[$pageId]['revid']

Follow-up revisions

RevisionCommit summaryAuthorDate
r72624Followup r72623, need to actually change how we're doing the comparison of "n...reedy01:21, 9 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72532ApiArticleAssessment:...reedy12:25, 7 September 2010

Status & tagging log