r72622 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72621‎ | r72622 | r72623 >
Date:00:53, 9 September 2010
Author:demon
Status:ok
Tags:
Comment:
(bug 25102) Image.php throws E_STRICT. Yes, this breaks back-compat, but nothing uses this anyway...mark it for removal in 1.18
Modified paths:
  • /trunk/phase3/includes/filerepo/Image.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/Image.php
@@ -8,7 +8,7 @@
99 /**
1010 * Backwards compatibility class
1111 *
12 - * @deprecated
 12+ * @deprecated. Will be removed in 1.18!
1313 * @ingroup FileRepo
1414 */
1515 class Image extends LocalFile {
@@ -23,7 +23,7 @@
2424 * Do not use in core code.
2525 * @deprecated
2626 */
27 - static function newFromTitle( $title, $time = false ) {
 27+ static function newFromTitle( $title, $repo, $time = null ) {
2828 wfDeprecated( __METHOD__ );
2929 $img = wfFindFile( $title, array( 'time' => $time ) );
3030 if ( !$img ) {

Status & tagging log