r72116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72115‎ | r72116 | r72117 >
Date:16:47, 1 September 2010
Author:reedy
Status:ok
Tags:
Comment:
* (bug 24166) API error when using rvprop=tags

Move addition of revision table to after other joins
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -136,7 +136,7 @@
137137 }
138138
139139 $db = $this->getDB();
140 - $this->addTables( array( 'page', 'revision' ) );
 140+ $this->addTables( 'page' );
141141 $this->addFields( Revision::selectFields() );
142142 $this->addWhere( 'page_id = rev_page' );
143143
@@ -202,6 +202,9 @@
203203 }
204204 }
205205
 206+ //Bug 24166 - API error when using rvprop=tags
 207+ $this->addTables( 'revision' );
 208+
206209 $userMax = ( $this->fld_content ? ApiBase::LIMIT_SML1 : ApiBase::LIMIT_BIG1 );
207210 $botMax = ( $this->fld_content ? ApiBase::LIMIT_SML2 : ApiBase::LIMIT_BIG2 );
208211 $limit = $params['limit'];
Index: trunk/phase3/RELEASE-NOTES
@@ -376,6 +376,7 @@
377377 * For required string parameters, if '' is provided, this is now classed as
378378 missing
379379 * (bug 24724) list=allusers is out by 1 (shows total users - 1)
 380+* (bug 24166) API error when using rvprop=tags
380381
381382 === Languages updated in 1.17 ===
382383

Follow-up revisions

RevisionCommit summaryAuthorDate
r72117MFT r72116 (bug 24166) API error when using rvprop=tagsreedy16:50, 1 September 2010
r77735MFT r72116demon18:52, 4 December 2010

Status & tagging log