r72117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72116‎ | r72117 | r72118 >
Date:16:50, 1 September 2010
Author:reedy
Status:deferred
Tags:
Comment:
MFT r72116 (bug 24166) API error when using rvprop=tags
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/api/ApiQueryRevisions.php
@@ -125,7 +125,7 @@
126126 }
127127
128128 $db = $this->getDB();
129 - $this->addTables( array( 'page', 'revision' ) );
 129+ $this->addTables( 'page' );
130130 $this->addFields( Revision::selectFields() );
131131 $this->addWhere( 'page_id = rev_page' );
132132
@@ -189,6 +189,9 @@
190190 $this->section = false;
191191 }
192192
 193+ //Bug 24166 - API error when using rvprop=tags
 194+ $this->addTables( 'revision' );
 195+
193196 $userMax = ( $this->fld_content ? ApiBase::LIMIT_SML1 : ApiBase::LIMIT_BIG1 );
194197 $botMax = ( $this->fld_content ? ApiBase::LIMIT_SML2 : ApiBase::LIMIT_BIG2 );
195198 $limit = $params['limit'];
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -47,6 +47,7 @@
4848 == Changes since 1.16.0 ==
4949 * (bug 24981) Allow extensions to access SpecialUpload variables again
5050 * (bug 24724) list=allusers is out by 1 (shows total users - 1)
 51+* (bug 24166) API error when using rvprop=tags
5152
5253 == Changes since 1.16 beta 3 ==
5354

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72116* (bug 24166) API error when using rvprop=tags...reedy16:47, 1 September 2010

Status & tagging log