r71929 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71928‎ | r71929 | r71930 >
Date:06:57, 30 August 2010
Author:siebrand
Status:resolved (Comments)
Tags:
Comment:
Only deny use of contact form if sending e-mail is blocked instead of blocking it when the user is blocked from regular editing.

Follows-up r71882 code review comments.
Modified paths:
  • /trunk/extensions/ContactPage/SpecialContact.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContactPage/SpecialContact.php
——@@ -53,7 +53,7 @@
5454 }
5555
5656 // Blocked users cannot use the contact form.
57 - if ( $wgUser->isBlocked() ) {
 57+ if ( $wgUser->isAllowed( 'sendemail' ) ) {
5858 $wgOut->setPageTitle( wfMsg( 'blockedtitle' ) );
5959 $wgOut->setRobotPolicy( 'noindex,nofollow' );
6060 $wgOut->setArticleRelated( false );

Follow-up revisions

RevisionCommit summaryAuthorDate
r74175Follow-up r71882 and r71929: Fix bug in r71929. Check should be reversed.siebrand23:13, 2 October 2010
r80845ContactPage extension fixes:...brion08:00, 24 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71882(bug 24391) Prevent use of Special:ContactPage for blocked users....siebrand12:31, 29 August 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   07:41, 24 January 2011

Check is using the wrong function; details on r74175

#Comment by Brion VIBBER (talk | contribs)   08:03, 24 January 2011

r80845 fixes this; marking resolved.

Status & tagging log