r71928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71927‎ | r71928 | r71929 >
Date:06:43, 30 August 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Small docs improvement
Modified paths:
  • /trunk/extensions/Maps/Services/Maps_MappingServices.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/Maps_MappingServices.php
@@ -1,26 +1,16 @@
22 <?php
33
44 /**
5 - * File holding the MapsMappingServices class.
6 - *
7 - * @file Maps_MappingServices.php
8 - * @ingroup Maps
9 - *
10 - * @author Jeroen De Dauw
11 - */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
17 -/**
18 - * Class serving as a factory for the MapsMappingService classes.
 5+ * Class for interaction with MappingService objects.
196 *
207 * @since 0.6.6
218 *
 9+ * @file Maps_MappingServices.php
 10+ * @ingroup Maps
 11+ *
2212 * @author Jeroen De Dauw
2313 */
24 -class MapsMappingServices {
 14+final class MapsMappingServices {
2515
2616 /**
2717 * Accociative array containing service identifiers as keys and the names
@@ -46,17 +36,6 @@
4737 */
4838 protected static $services = array();
4939
50 -/* TODO
51 - // Remove all hooked in services that should not be available.
52 - foreach ( $egMapsServices as $service => $data ) {
53 - if ( !in_array( $service, $egMapsAvailableServices ) ) unset( $egMapsServices[$service] );
54 - }
55 - $egMapsAvailableServices = array_keys( $egMapsServices );
56 -
57 - // Enure that the default service is one of the enabled ones.
58 - $egMapsDefaultService = in_array( $egMapsDefaultService, $egMapsAvailableServices ) ? $egMapsDefaultService : $egMapsAvailableServices[0];
59 - */
60 -
6140 /**
6241 * Registeres a service class linked to an identifier.
6342 * Also allows automatic registration of a list of features for this service.

Status & tagging log