r71927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71926‎ | r71927 | r71928 >
Date:05:14, 30 August 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r71926: fix PagedTiffHandler readdir() slowdown.
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/PagedTiffHandler (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/PagedTiffHandler/PagedTiffHandler_body.php
@@ -374,7 +374,7 @@
375375 && $meta['page_data'][$page]['pixels'] > $wgMaxImageArea )
376376 return $this->doThumbError( $params, 'tiff_sourcefile_too_large' );
377377 $cmd = wfEscapeShellArg( $wgImageMagickConvertCommand );
378 - $cmd .= " " . wfEscapeShellArg( $srcPath ) . "[" . ( $page - 1 ) . "]";
 378+ $cmd .= " " . wfEscapeShellArg( $srcPath . "[" . ( $page - 1 ) . "]" );
379379 $cmd .= " -depth 8 -resize {$width} ";
380380 $cmd .= wfEscapeShellArg( $dstPath );
381381 }
Property changes on: branches/wmf/1.16wmf4/extensions/PagedTiffHandler
___________________________________________________________________
Modified: svn:mergeinfo
382382 Merged /trunk/extensions/PagedTiffHandler:r71922-71926

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71926When calling ImageMagick, put the scene specification inside the shell quotes...tstarling05:11, 30 August 2010

Status & tagging log