r71895 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71894‎ | r71895 | r71896 >
Date:19:07, 29 August 2010
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Use <<<HTML for vim docstring syntax highlighting

This way vim highlights the docstring as HTML instead of plaintext,
which is nice.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
——@@ -1559,13 +1559,13 @@
15601560 protected function showFormBeforeText() {
15611561 global $wgOut;
15621562 $section = htmlspecialchars( $this->section );
1563 - $wgOut->addHTML( <<<INPUTS
 1563+ $wgOut->addHTML( <<<HTML
15641564 <input type='hidden' value="{$section}" name="wpSection" />
15651565 <input type='hidden' value="{$this->starttime}" name="wpStarttime" />
15661566 <input type='hidden' value="{$this->edittime}" name="wpEdittime" />
15671567 <input type='hidden' value="{$this->scrolltop}" name="wpScrolltop" id="wpScrolltop" />
15681568
1569 -INPUTS
 1569+HTML
15701570 );
15711571 if ( !$this->checkUnicodeCompliantBrowser() )
15721572 $wgOut->addHTML(Xml::hidden( 'safemode', '1' ));

Comments

#Comment by Nikerabbit (talk | contribs)   20:32, 29 August 2010

Why is that even constructing the html manually?

Status & tagging log