r71896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71895‎ | r71896 | r71897 >
Date:19:11, 29 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r32776.
$log->addEntry got added an extra indentation, which was wrong.
Functionality was right. It goes *outside* the if
Modified paths:
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileDeleteForm.php
@@ -110,9 +110,10 @@
111111 // Need to do a log item
112112 $log = new LogPage( 'delete' );
113113 $logComment = wfMsgForContent( 'deletedrevision', $oldimage );
114 - if( trim( $reason ) != '' )
 114+ if( trim( $reason ) != '' ) {
115115 $logComment .= wfMsgForContent( 'colon-separator' ) . $reason;
116 - $log->addEntry( 'delete', $title, $logComment );
 116+ }
 117+ $log->addEntry( 'delete', $title, $logComment );
117118 }
118119 } else {
119120 $id = $title->getArticleID( GAID_FOR_UPDATE );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r32776Moved file deletion code to a more abstract FileDeleteForm::doDeletebtongminh12:16, 4 April 2008

Status & tagging log