r71680 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r71679‎ | r71680 | r71681 >
Date:00:28, 26 August 2010
Author:awjrichards
Status:deferred (Comments)
Tags:
Comment:
Updated to default to , as per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71642#c8693
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php
——@@ -35,8 +35,8 @@
3636 * to help prevent CSRF, etc. PLEASE use this!
3737 * Declare in LocalSettings.php
3838 */
39 -global $wgPayflowGatewaySalt;
40 -$wgPayflowGatewaySalt = '';
 39+global $wgPayflowGatewaySalt, $wgSecretKey;
 40+$wgPayflowGatewaySalt = $wgSecretKey;
4141
4242 /**
4343 * Your minFraud license key.

Comments

#Comment by Reedy (talk | contribs)   03:03, 26 August 2010

Special:Code/MediaWiki/71642#c8693 would be a bit shorter ;)

#Comment by Platonides (talk | contribs)   11:48, 26 August 2010

You don't need globals in that file, since it's loaded in the globla context (and if it wasn't, $wgExtensionCredits, $wgAutoloadClasses and $wgHooks would need it, too).

#Comment by Awjrichards (talk | contribs)   17:41, 26 August 2010

true story, thnx

Status & tagging log