r71681 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71680‎ | r71681 | r71682 >
Date:00:30, 26 August 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Updated location of declaration of
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.php
@@ -29,16 +29,6 @@
3030 $wgPayflowGatewayLog = '';
3131
3232 /**
33 - * Custom string for 'salting' hashes
34 - *
35 - * Used to help make hashes harder to predict by potential attackers
36 - * to help prevent CSRF, etc. PLEASE use this!
37 - * Declare in LocalSettings.php
38 - */
39 -global $wgPayflowGatewaySalt, $wgSecretKey;
40 -$wgPayflowGatewaySalt = $wgSecretKey;
41 -
42 -/**
4333 * Your minFraud license key.
4434 */
4535 global $wgMinFraudLicenseKey;
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php
@@ -45,7 +45,8 @@
4646 * potentially leave you and your users vulnerable to CSRF or other forms of
4747 * attack.
4848 */
49 -$wgPayflowGatewaySalt = '';
 49+global $wgPayflowGatewaySalt, $wgSecretKey;
 50+$wgPayflowGatewaySalt = $wgSecretKey;
5051
5152 global $wgPayflowGatewayDBserver, $wgPayflowGatewayDBname, $wgPayflowGatewayDBuser, $wgPayflowGatewayDBpassword;
5253 $wgPayflowGatewayDBserver = $wgDBserver;

Status & tagging log