r71253 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71252‎ | r71253 | r71254 >
Date:13:55, 18 August 2010
Author:reedy
Status:reverted
Tags:
Comment:
Remove some more parameters post r71250
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -929,7 +929,6 @@
930930 $conf->RootUser,
931931 $conf->RootPW,
932932 false,
933 - false,
934933 1
935934 );
936935 if ( !$wgDatabase->isOpen() ) {
@@ -1049,7 +1048,7 @@
10501049 $wgDBadminuser = $conf->RootUser;
10511050 $wgDBadminpassword = $conf->RootPW;
10521051 echo "<li>Attempting to create DB user.</li>";
1053 - $wgDatabase = $dbc->newFromParams('DUMMY', $wgDBadminuser, $wgDBadminpassword, $wgDBname, 1, 64);
 1052+ $wgDatabase = $dbc->newFromParams('DUMMY', $wgDBadminuser, $wgDBadminpassword, $wgDBname, 64);
10541053 if ($wgDatabase->isOpen()) {
10551054 $wgDBOracleDefTS = $conf->DBdefTS_ora;
10561055 $wgDBOracleTempTS = $conf->DBtempTS_ora;

Follow-up revisions

RevisionCommit summaryAuthorDate
r71254Revert r71250 r71251 r71252 r71253...reedy14:15, 18 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71250Kill some crappy "failFunction" stuff, marked as old in r14625reedy13:38, 18 August 2010

Status & tagging log