r71252 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71251‎ | r71252 | r71253 >
Date:13:50, 18 August 2010
Author:reedy
Status:reverted
Tags:
Comment:
Fix wrong removal in r71250
Modified paths:
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -183,7 +183,7 @@
184184 wfDebug( "DB connection error\n" );
185185 wfDebug( "Server: $server, Database: $dbName, User: $user, Password: " . substr( $password, 0, 3 ) . "...\n" );
186186 wfDebug( $this->lastError()."\n" );
187 - return false;
 187+ throw new DBConnectionError( $this, $phpError );
188188 }
189189
190190 $this->mOpened = true;
Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -89,7 +89,7 @@
9090 }
9191 if ( $this->mConn === false ) {
9292 wfDebug( "DB connection error: $err\n" );
93 - return false;
 93+ throw new DBConnectionError( $this, $err );
9494 }
9595 $this->mOpened = !!$this->mConn;
9696 # set error codes only, don't raise exceptions

Follow-up revisions

RevisionCommit summaryAuthorDate
r71254Revert r71250 r71251 r71252 r71253...reedy14:15, 18 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71250Kill some crappy "failFunction" stuff, marked as old in r14625reedy13:38, 18 August 2010

Status & tagging log