r70962 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70961‎ | r70962 | r70963 >
Date:14:46, 12 August 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Added missing $ to variable.
Removing (unused) global $wgDBts2schema about Postgres tsearch2
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -509,7 +509,7 @@
510510 function insertSelect( $destTable, $srcTable, $varMap, $conds, $fname = 'Database::insertSelect',
511511 $insertOptions = array(), $selectOptions = array() )
512512 {
513 - $ret = parent::insertSelect( $destTable, $srcTable, $varMap, $conds, $fname, insertOptions, $selectOptions );
 513+ $ret = parent::insertSelect( $destTable, $srcTable, $varMap, $conds, $fname, $insertOptions, $selectOptions );
514514
515515 if ( $ret === false ) {
516516 throw new DBQueryError( $this, $this->getErrors(), $this->lastErrno(), $sql, $fname );
@@ -814,7 +814,7 @@
815815 }
816816
817817 function setup_database() {
818 - global $wgVersion, $wgDBmwschema, $wgDBts2schema, $wgDBport, $wgDBuser;
 818+ global $wgVersion, $wgDBmwschema, $wgDBport, $wgDBuser;
819819
820820 // Make sure that we can write to the correct schema
821821 $ctest = "mediawiki_test_table";

Comments

#Comment by Platonides (talk | contribs)   14:47, 12 August 2010

(Follow up to r70608)

Status & tagging log