r70963 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70962‎ | r70963 | r70964 >
Date:14:50, 12 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r69543, r70608
Remove unused $wgSuperUser and superflous non-global $wgDBsuperuser.
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
@@ -921,11 +921,9 @@
922922 }
923923 else if ( $conf->DBtype == 'mssql' ) {
924924 error_reporting( E_ALL );
925 - $wgSuperUser = '';
926 - # # Possible connect as a superuser
 925+ # Possible connect as a superuser
927926 if ( $useRoot ) {
928 - $wgDBsuperuser = $conf->RootUser;
929 - echo( "<li>Attempting to connect to database \"{$conf->DBtype}\" as superuser \"{$wgDBsuperuser}\"" );
 927+ echo( "<li>Attempting to connect to database \"{$conf->DBtype}\" as superuser \"{$conf->RootUser}\"" );
930928 $wgDatabase = $dbc->newFromParams(
931929 $conf->DBserver,
932930 $conf->RootUser,
@@ -1080,7 +1078,6 @@
10811079 }
10821080 } else { # not mysql
10831081 error_reporting( E_ALL | E_STRICT );
1084 - $wgSuperUser = '';
10851082 ## Possible connect as a superuser
10861083 // Changed !mysql to postgres check since it seems to only apply to postgres
10871084 if( $useRoot && $conf->DBtype == 'postgres' ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69543* 2009 -> 2010danny_b12:31, 19 July 2010
r70608DatabaseMssql class and related changesyaauie23:44, 6 August 2010

Status & tagging log