r70706 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70705‎ | r70706 | r70707 >
Date:15:30, 8 August 2010
Author:demon
Status:ok
Tags:
Comment:
Remove OK message for SQLite search. Outputs as warning and is potentially confusing
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -275,7 +275,6 @@
276276 'config-sqlite-cant-create-db' => 'Could not create database file <code>$1</code>.',
277277 'config-sqlite-fts3-downgrade' => 'PHP is missing FTS3 support, downgrading tables',
278278 'config-sqlite-fts3-add' => 'Adding FTS3 search capabilities',
279 - 'config-sqlite-fts3-ok' => 'Full text search table appears to be in order',
280279 'config-can-upgrade' => "There are MediaWiki tables in this database.
281280 To upgrade them to MediaWiki $1, click '''Continue'''.",
282281 'config-upgrade-done' => "Upgrade complete.
Index: trunk/phase3/includes/installer/SqliteInstaller.php
@@ -180,10 +180,7 @@
181181 } elseif ( !$fts3tTable && $module == 'FTS3' ) {
182182 $status->warning( 'config-sqlite-fts3-add' );
183183 $this->db->sourceFile( "$IP/maintenance/sqlite/archives/searchindex-fts3.sql" );
184 - } else {
185 - $status->warning( 'config-sqlite-fts3-ok' );
186184 }
187 -
188185 return $status;
189186 }
190187

Status & tagging log