r70707 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70706‎ | r70707 | r70708 >
Date:15:33, 8 August 2010
Author:soxred93
Status:ok
Tags:
Comment:
(bug 24722) Only show blockinfo if user is actually blocked for list=allusers
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -157,7 +157,7 @@
158158 // Record new user's data
159159 $lastUser = $row->user_name;
160160 $lastUserData = array( 'name' => $lastUser );
161 - if ( $fld_blockinfo ) {
 161+ if ( $fld_blockinfo && !is_null( $row->blocker_name ) ) {
162162 $lastUserData['blockedby'] = $row->blocker_name;
163163 $lastUserData['blockreason'] = $row->ipb_reason;
164164 }
Index: trunk/phase3/RELEASE-NOTES
@@ -336,7 +336,9 @@
337337 allpages, and allusers
338338 * (bug 24236) Add add, remove, add-self, remove-self tags to meta=siteinfo&siprop=usergroups
339339 * (bug 24484) Add prop=pageprops module
340 -* (bug 24330) Add &redirect parameter to ?action=edit
 340+* (bug 24330) Add &redirect parameter to ?action=edit
 341+* (bug 24722) For list=allusers&auprop=blockinfo, only show blockedby and blockreason if
 342+ the user is actually blocked.
341343
342344 === Languages updated in 1.17 ===
343345

Status & tagging log