r70705 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70704‎ | r70705 | r70706 >
Date:15:29, 8 August 2010
Author:demon
Status:ok
Tags:
Comment:
Tweak output from install. Make non-fatals still say OK, but output their possible warnings.
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -832,14 +832,13 @@
833833 }
834834
835835 public function endStage( $step, $status ) {
836 - $success = $status->isGood();
837 - $msg = $success ? 'config-install-step-done' : 'config-install-step-failed';
 836+ $msg = $status->isOk() ? 'config-install-step-done' : 'config-install-step-failed';
838837 $html = wfMsgHtml( 'word-separator' ) . wfMsgHtml( $msg );
839 - if ( !$success ) {
 838+ if ( !$status->isOk() ) {
840839 $html = "<span class=\"error\">$html</span>";
841840 }
842841 $this->addHTML( $html . "</li>\n" );
843 - if( !$success ) {
 842+ if( !$status->isGood() ) {
844843 $this->parent->showStatusBox( $status );
845844 }
846845 }

Status & tagging log