r70661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70660‎ | r70661 | r70662 >
Date:05:21, 8 August 2010
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
Fixed minor logic error that caused layout issues
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -394,13 +394,15 @@
395395 if( !$this->firstExtOpened ) {
396396 // Insert a spacing line
397397 $out .= '<tr class="sv-space">' . Html::element( 'td', $opt ) . "</tr>\n";
 398+ $this->firstExtOpened = true;
398399 }
399 - $this->firstExtOpened = false;
400400
401 - if( $name )
 401+ if( $name ) {
402402 $opt['id'] = "sv-$name";
 403+ }
403404
404405 $out .= "<tr>" . Xml::element( 'th', $opt, $text ) . "</tr>\n";
 406+
405407 return $out;
406408 }
407409

Follow-up revisions

RevisionCommit summaryAuthorDate
r70724Follow up to r70661. Restored original behavior but with logical use of the b...jeroendedauw22:05, 8 August 2010

Comments

#Comment by Simetrical (talk | contribs)   20:40, 8 August 2010

Please describe the layout issues you saw that this fixed, so that your commit can be reviewed easily.

#Comment by Platonides (talk | contribs)   20:49, 8 August 2010

Now firstExtOpened is never false.

#Comment by Jeroen De Dauw (talk | contribs)   22:07, 8 August 2010

I thought this was an error, as the values assigned to firstExtOpened did not make sense (they had true instead of false and the other way around). Now restored original behaviour but with the values corrected.

#Comment by Platonides (talk | contribs)   22:19, 8 August 2010

In such case you should blame when it was added (r18903), look if it made sense then (the conditions could be different, anothe revision could have disabled it) and if it still looks broken at least reference the guilty revision so that the author gets a trackback.

Status & tagging log