r70724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70723‎ | r70724 | r70725 >
Date:22:05, 8 August 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Follow up to r70661. Restored original behavior but with logical use of the boolean.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -27,7 +27,7 @@
2828 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
2929 */
3030 class SpecialVersion extends SpecialPage {
31 - private $firstExtOpened = true;
 31+ private $firstExtOpened = false;
3232
3333 static $viewvcUrls = array(
3434 'svn+ssh://svn.wikimedia.org/svnroot/mediawiki' => 'http://svn.wikimedia.org/viewvc/mediawiki',
@@ -391,12 +391,12 @@
392392 $opt = array( 'colspan' => 4 );
393393 $out = '';
394394
395 - if( !$this->firstExtOpened ) {
 395+ if( $this->firstExtOpened ) {
396396 // Insert a spacing line
397397 $out .= '<tr class="sv-space">' . Html::element( 'td', $opt ) . "</tr>\n";
398 - $this->firstExtOpened = true;
399398 }
400 -
 399+ $this->firstExtOpened = true;
 400+
401401 if( $name ) {
402402 $opt['id'] = "sv-$name";
403403 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70661Fixed minor logic error that caused layout issuesjeroendedauw05:21, 8 August 2010

Status & tagging log