r70618 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70617‎ | r70618 | r70619 >
Date:05:20, 7 August 2010
Author:huji
Status:ok (Comments)
Tags:
Comment:
Updating main-ltr.css for Vector skin to ensure the RTL stylesheet mirros all items from the LTR layout correctly. (See comments on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70549)
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -405,6 +405,7 @@
406406 }
407407 div#mw-panel div.portal {
408408 padding-bottom: 1.5em;
 409+ direction: ltr;
409410 }
410411 div#mw-panel div.portal h5 {
411412 font-weight: normal;
——@@ -453,6 +454,7 @@
454455 background-image: url(images/border.png?1);
455456 background-position: top left;
456457 background-repeat: repeat-x;
 458+ direction: ltr;
457459 }
458460 div#footer ul {
459461 list-style: none;
——@@ -705,6 +707,7 @@
706708 h5 .editsection { font-weight: normal; }
707709 h6 { font-size: 80%; }
708710 h6 .editsection { font-size: 125%; font-weight: normal; }
 711+.editsection { float: right; }
709712 p {
710713 margin: .4em 0 .5em 0;
711714 line-height: 1.5em;
——@@ -1149,3 +1152,9 @@
11501153 background-position:right bottom;
11511154 background-repeat:no-repeat;
11521155 }
 1156+
 1157+/* Convenience links to edit block, delete and protect reasons */
 1158+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
 1159+p.mw-filedelete-editreasons, p.mw-delete-editreasons {
 1160+ float: right;
 1161+}

Comments

#Comment by Raymond (talk | contribs)   08:26, 7 August 2010

+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons, +p.mw-filedelete-editreasons, p.mw-delete-editreasons {

are defined in skins/common/shares.css and skins/common/common_rtl.css (the latter with float: left)

These files are loaded for vector too.

#Comment by Huji (talk | contribs)   15:27, 7 August 2010

Yes, but somehow, without that change, those elements are floated to left both in the RTL and the LTR layout of Vector skin.

#Comment by Huji (talk | contribs)   15:28, 7 August 2010

In Monobook skin, those elements are overriden in /monobook/rtl.css setting float attribute to right.

If you think this form of overriding is wrong, then we should fix it in Monobook too.

#Comment by Siebrand (talk | contribs)   16:02, 23 October 2010

MonoBook was recently ported to use Resource Loader (r74966) and uses a lot now of what Vector uses. This has probably been fixed. Marking new fow now.

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:23, 12 January 2011

This seems to be overriding a result of shared and common_rtl being auto-flipped by ResourceLoader, and then fighting with each other. This is a big mess. This rule should be removed from Vector and any other skins it's been added to, common_rtl should be deleted, and RTL rules in shared should be removed, unless they are special in that they are not obvious mirrored versions of the ltr rules, in which case they should be kept but preceeded with a /* @noflip */ comment.

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:31, 12 January 2011

I was specifically talking about the section labeled /* Convenience links to edit block, delete and protect reasons */ - sorry if that was unclear.

Status & tagging log