r70617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70616‎ | r70617 | r70618 >
Date:05:10, 7 August 2010
Author:maxsem
Status:ok
Tags:
Comment:
Follow-up r70608: you don't need to override this stuff with empty functions, they're empty in the base class already
Modified paths:
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -1011,31 +1011,7 @@
10121012 return array( $startOpts, '' , $tailOpts, '' );
10131013 }
10141014
1015 - public function setTimeout( $timeout ) {
1016 - // couldn't find any timeout functions
1017 - }
1018 -
1019 - function ping() {
1020 - wfDebug( "Function ping() not written for MSSQL Native yet" );
1021 - return true;
1022 - }
1023 -
10241015 /**
1025 - * How lagged is this slave?
1026 - *
1027 - */
1028 - public function getLag() {
1029 - # Not implemented for MSSQL
1030 - return false;
1031 - }
1032 -
1033 - /**
1034 - * FIXME: Add lag support
1035 - */
1036 - function setFakeSlaveLag( $lag ) { }
1037 - function setFakeMaster( $enabled = false ) { }
1038 -
1039 - /**
10401016 * Get the type of the DBMS, as it appears in $wgDBtype.
10411017 */
10421018 function getType(){

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70608DatabaseMssql class and related changesyaauie23:44, 6 August 2010

Status & tagging log