r70549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70548‎ | r70549 | r70550 >
Date:10:33, 6 August 2010
Author:huji
Status:resolved (Comments)
Tags:
Comment:
Updating main-rtl.css for Vector skin to ensure all left-aligned (or left-directioned) elements of the page are mirrored to right correctly.
Modified paths:
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -36,6 +36,7 @@
3737 background-repeat: repeat-y;
3838 background-color: white;
3939 color: black;
 40+ direction: rtl;
4041 }
4142 /* Head */
4243 #mw-page-base {
——@@ -406,6 +407,7 @@
407408 }
408409 div#mw-panel div.portal {
409410 padding-bottom: 1.5em;
 411+ direction: rtl;
410412 }
411413 div#mw-panel div.portal h5 {
412414 font-weight: normal;
——@@ -454,6 +456,7 @@
455457 background-image: url(images/border.png?1);
456458 background-position: top right;
457459 background-repeat: repeat-x;
 460+ direction: rtl;
458461 }
459462 div#footer ul {
460463 list-style: none;

Comments

#Comment by Catrope (talk | contribs)   10:35, 6 August 2010

main-rtl.css is automatically generated from main-ltr.css, so any changes need to be made in both files.

#Comment by Huji (talk | contribs)   22:19, 6 August 2010

Oops, my bad.

I assume I have to add "direction: ltr"s in the main-ltr.css file, right?

#Comment by Catrope (talk | contribs)   22:42, 6 August 2010

I think so; I'll ask Trevor (the author of Vector) to chip in.

P.S.: You don't need to notify me on my talk page: any comments on this revision will trigger an e-mail notification from CodeReview for the committer and all previous commenters.

#Comment by Trevor Parscal (WMF) (talk | contribs)   22:46, 6 August 2010

You should never edit the RTL version. If you need the direction property, put it in the LTR version as direction: ltr; and it will automatically transform it when you rebuild the RTL file.

#Comment by Huji (talk | contribs)   05:20, 7 August 2010

r70618 should fix it.

#Comment by Huji (talk | contribs)   05:22, 7 August 2010

Trevor, can you please recheck if r70618 also fixes r70551 and r70552?

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:14, 12 January 2011

This file doesn't even exist anymore. CSSJanus is used by ResourceLoader to automatically flip things. This file should have never been edited in the first place (as per the comment at the top) - the changes made here should have been made in the ltr file.

Status & tagging log