r70138 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r70137‎ \| r70138 \| r70139 >
Date:	13:56, 29 July 2010
Author:	btongminh
Status:	resolved (Comments)
Tags:
Comment:	Follow-up r70137, messages: * Renamed successfulupload to upload-success-msg * Renamed upload-successful-subj to upload-success-subj * Added upload-warning-subj and upload-warning-msg
Modified paths:	/trunk/phase3/languages/messages/MessagesAf.php (modified) (history) /trunk/phase3/languages/messages/MessagesAm.php (modified) (history) /trunk/phase3/languages/messages/MessagesAn.php (modified) (history) /trunk/phase3/languages/messages/MessagesAr.php (modified) (history) /trunk/phase3/languages/messages/MessagesArz.php (modified) (history) /trunk/phase3/languages/messages/MessagesAs.php (modified) (history) /trunk/phase3/languages/messages/MessagesAst.php (modified) (history) /trunk/phase3/languages/messages/MessagesAvk.php (modified) (history) /trunk/phase3/languages/messages/MessagesAz.php (modified) (history) /trunk/phase3/languages/messages/MessagesBar.php (modified) (history) /trunk/phase3/languages/messages/MessagesBat_smg.php (modified) (history) /trunk/phase3/languages/messages/MessagesBcc.php (modified) (history) /trunk/phase3/languages/messages/MessagesBcl.php (modified) (history) /trunk/phase3/languages/messages/MessagesBe.php (modified) (history) /trunk/phase3/languages/messages/MessagesBe_tarask.php (modified) (history) /trunk/phase3/languages/messages/MessagesBg.php (modified) (history) /trunk/phase3/languages/messages/MessagesBn.php (modified) (history) /trunk/phase3/languages/messages/MessagesBr.php (modified) (history) /trunk/phase3/languages/messages/MessagesBs.php (modified) (history) /trunk/phase3/languages/messages/MessagesCa.php (modified) (history) /trunk/phase3/languages/messages/MessagesCdo.php (modified) (history) /trunk/phase3/languages/messages/MessagesCkb_arab.php (modified) (history) /trunk/phase3/languages/messages/MessagesCrh_cyrl.php (modified) (history) /trunk/phase3/languages/messages/MessagesCrh_latn.php (modified) (history) /trunk/phase3/languages/messages/MessagesCs.php (modified) (history) /trunk/phase3/languages/messages/MessagesCsb.php (modified) (history) /trunk/phase3/languages/messages/MessagesCu.php (modified) (history) /trunk/phase3/languages/messages/MessagesCv.php (modified) (history) /trunk/phase3/languages/messages/MessagesCy.php (modified) (history) /trunk/phase3/languages/messages/MessagesDa.php (modified) (history) /trunk/phase3/languages/messages/MessagesDe.php (modified) (history) /trunk/phase3/languages/messages/MessagesDiq.php (modified) (history) /trunk/phase3/languages/messages/MessagesDsb.php (modified) (history) /trunk/phase3/languages/messages/MessagesEl.php (modified) (history) /trunk/phase3/languages/messages/MessagesEn.php (modified) (history) /trunk/phase3/languages/messages/MessagesEo.php (modified) (history) /trunk/phase3/languages/messages/MessagesEs.php (modified) (history) /trunk/phase3/languages/messages/MessagesEt.php (modified) (history) /trunk/phase3/languages/messages/MessagesEu.php (modified) (history) /trunk/phase3/languages/messages/MessagesExt.php (modified) (history) /trunk/phase3/languages/messages/MessagesFa.php (modified) (history) /trunk/phase3/languages/messages/MessagesFi.php (modified) (history) /trunk/phase3/languages/messages/MessagesFo.php (modified) (history) /trunk/phase3/languages/messages/MessagesFr.php (modified) (history) /trunk/phase3/languages/messages/MessagesFrp.php (modified) (history) /trunk/phase3/languages/messages/MessagesFur.php (modified) (history) /trunk/phase3/languages/messages/MessagesFy.php (modified) (history) /trunk/phase3/languages/messages/MessagesGa.php (modified) (history) /trunk/phase3/languages/messages/MessagesGan_hans.php (modified) (history) /trunk/phase3/languages/messages/MessagesGan_hant.php (modified) (history) /trunk/phase3/languages/messages/MessagesGl.php (modified) (history) /trunk/phase3/languages/messages/MessagesGrc.php (modified) (history) /trunk/phase3/languages/messages/MessagesGsw.php (modified) (history) /trunk/phase3/languages/messages/MessagesHak.php (modified) (history) /trunk/phase3/languages/messages/MessagesHe.php (modified) (history) /trunk/phase3/languages/messages/MessagesHi.php (modified) (history) /trunk/phase3/languages/messages/MessagesHif_latn.php (modified) (history) /trunk/phase3/languages/messages/MessagesHr.php (modified) (history) /trunk/phase3/languages/messages/MessagesHsb.php (modified) (history) /trunk/phase3/languages/messages/MessagesHu.php (modified) (history) /trunk/phase3/languages/messages/MessagesHy.php (modified) (history) /trunk/phase3/languages/messages/MessagesIa.php (modified) (history) /trunk/phase3/languages/messages/MessagesId.php (modified) (history) /trunk/phase3/languages/messages/MessagesIlo.php (modified) (history) /trunk/phase3/languages/messages/MessagesIo.php (modified) (history) /trunk/phase3/languages/messages/MessagesIs.php (modified) (history) /trunk/phase3/languages/messages/MessagesIt.php (modified) (history) /trunk/phase3/languages/messages/MessagesJa.php (modified) (history) /trunk/phase3/languages/messages/MessagesJv.php (modified) (history) /trunk/phase3/languages/messages/MessagesKa.php (modified) (history) /trunk/phase3/languages/messages/MessagesKaa.php (modified) (history) /trunk/phase3/languages/messages/MessagesKab.php (modified) (history) /trunk/phase3/languages/messages/MessagesKk_arab.php (modified) (history) /trunk/phase3/languages/messages/MessagesKk_cyrl.php (modified) (history) /trunk/phase3/languages/messages/MessagesKk_latn.php (modified) (history) /trunk/phase3/languages/messages/MessagesKm.php (modified) (history) /trunk/phase3/languages/messages/MessagesKn.php (modified) (history) /trunk/phase3/languages/messages/MessagesKo.php (modified) (history) /trunk/phase3/languages/messages/MessagesKrc.php (modified) (history) /trunk/phase3/languages/messages/MessagesKsh.php (modified) (history) /trunk/phase3/languages/messages/MessagesKu_latn.php (modified) (history) /trunk/phase3/languages/messages/MessagesLa.php (modified) (history) /trunk/phase3/languages/messages/MessagesLb.php (modified) (history) /trunk/phase3/languages/messages/MessagesLi.php (modified) (history) /trunk/phase3/languages/messages/MessagesLt.php (modified) (history) /trunk/phase3/languages/messages/MessagesLv.php (modified) (history) /trunk/phase3/languages/messages/MessagesLzh.php (modified) (history) /trunk/phase3/languages/messages/MessagesMdf.php (modified) (history) /trunk/phase3/languages/messages/MessagesMg.php (modified) (history) /trunk/phase3/languages/messages/MessagesMk.php (modified) (history) /trunk/phase3/languages/messages/MessagesMl.php (modified) (history) /trunk/phase3/languages/messages/MessagesMn.php (modified) (history) /trunk/phase3/languages/messages/MessagesMr.php (modified) (history) /trunk/phase3/languages/messages/MessagesMs.php (modified) (history) /trunk/phase3/languages/messages/MessagesMt.php (modified) (history) /trunk/phase3/languages/messages/MessagesMyv.php (modified) (history) /trunk/phase3/languages/messages/MessagesNah.php (modified) (history) /trunk/phase3/languages/messages/MessagesNan.php (modified) (history) /trunk/phase3/languages/messages/MessagesNds.php (modified) (history) /trunk/phase3/languages/messages/MessagesNds_nl.php (modified) (history) /trunk/phase3/languages/messages/MessagesNe.php (modified) (history) /trunk/phase3/languages/messages/MessagesNl.php (modified) (history) /trunk/phase3/languages/messages/MessagesNl_informal.php (modified) (history) /trunk/phase3/languages/messages/MessagesNn.php (modified) (history) /trunk/phase3/languages/messages/MessagesNo.php (modified) (history) /trunk/phase3/languages/messages/MessagesOc.php (modified) (history) /trunk/phase3/languages/messages/MessagesOs.php (modified) (history) /trunk/phase3/languages/messages/MessagesPa.php (modified) (history) /trunk/phase3/languages/messages/MessagesPam.php (modified) (history) /trunk/phase3/languages/messages/MessagesPl.php (modified) (history) /trunk/phase3/languages/messages/MessagesPms.php (modified) (history) /trunk/phase3/languages/messages/MessagesPnb.php (modified) (history) /trunk/phase3/languages/messages/MessagesPrg.php (modified) (history) /trunk/phase3/languages/messages/MessagesPs.php (modified) (history) /trunk/phase3/languages/messages/MessagesPt.php (modified) (history) /trunk/phase3/languages/messages/MessagesPt_br.php (modified) (history) /trunk/phase3/languages/messages/MessagesQu.php (modified) (history) /trunk/phase3/languages/messages/MessagesRo.php (modified) (history) /trunk/phase3/languages/messages/MessagesRoa_tara.php (modified) (history) /trunk/phase3/languages/messages/MessagesRu.php (modified) (history) /trunk/phase3/languages/messages/MessagesRue.php (modified) (history) /trunk/phase3/languages/messages/MessagesSah.php (modified) (history) /trunk/phase3/languages/messages/MessagesSc.php (modified) (history) /trunk/phase3/languages/messages/MessagesScn.php (modified) (history) /trunk/phase3/languages/messages/MessagesSdc.php (modified) (history) /trunk/phase3/languages/messages/MessagesSe.php (modified) (history) /trunk/phase3/languages/messages/MessagesSi.php (modified) (history) /trunk/phase3/languages/messages/MessagesSk.php (modified) (history) /trunk/phase3/languages/messages/MessagesSl.php (modified) (history) /trunk/phase3/languages/messages/MessagesSli.php (modified) (history) /trunk/phase3/languages/messages/MessagesSq.php (modified) (history) /trunk/phase3/languages/messages/MessagesSr_ec.php (modified) (history) /trunk/phase3/languages/messages/MessagesSr_el.php (modified) (history) /trunk/phase3/languages/messages/MessagesStq.php (modified) (history) /trunk/phase3/languages/messages/MessagesSu.php (modified) (history) /trunk/phase3/languages/messages/MessagesSv.php (modified) (history) /trunk/phase3/languages/messages/MessagesSw.php (modified) (history) /trunk/phase3/languages/messages/MessagesSzl.php (modified) (history) /trunk/phase3/languages/messages/MessagesTa.php (modified) (history) /trunk/phase3/languages/messages/MessagesTe.php (modified) (history) /trunk/phase3/languages/messages/MessagesTg_cyrl.php (modified) (history) /trunk/phase3/languages/messages/MessagesTg_latn.php (modified) (history) /trunk/phase3/languages/messages/MessagesTh.php (modified) (history) /trunk/phase3/languages/messages/MessagesTk.php (modified) (history) /trunk/phase3/languages/messages/MessagesTl.php (modified) (history) /trunk/phase3/languages/messages/MessagesTo.php (modified) (history) /trunk/phase3/languages/messages/MessagesTr.php (modified) (history) /trunk/phase3/languages/messages/MessagesTt_latn.php (modified) (history) /trunk/phase3/languages/messages/MessagesUg_arab.php (modified) (history) /trunk/phase3/languages/messages/MessagesUk.php (modified) (history) /trunk/phase3/languages/messages/MessagesVec.php (modified) (history) /trunk/phase3/languages/messages/MessagesVep.php (modified) (history) /trunk/phase3/languages/messages/MessagesVi.php (modified) (history) /trunk/phase3/languages/messages/MessagesVo.php (modified) (history) /trunk/phase3/languages/messages/MessagesVro.php (modified) (history) /trunk/phase3/languages/messages/MessagesWa.php (modified) (history) /trunk/phase3/languages/messages/MessagesWo.php (modified) (history) /trunk/phase3/languages/messages/MessagesWuu.php (modified) (history) /trunk/phase3/languages/messages/MessagesXal.php (modified) (history) /trunk/phase3/languages/messages/MessagesYi.php (modified) (history) /trunk/phase3/languages/messages/MessagesYo.php (modified) (history) /trunk/phase3/languages/messages/MessagesYue.php (modified) (history) /trunk/phase3/languages/messages/MessagesZh_hans.php (modified) (history) /trunk/phase3/languages/messages/MessagesZh_hant.php (modified) (history) /trunk/phase3/languages/messages/MessagesZu.php (modified) (history) /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r73347	Followup r70138, add message descriptions	demon	23:17, 19 September 2010

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r70137	Made asynchronous upload by URL working, partly. Hid it behind $wgAllowAsyncC...	btongminh	13:53, 29 July 2010

Comments

#Comment by Nikerabbit (talk | contribs) 04:29, 4 August 2010

Can you document at least parameters for upload-success-msg and upload-failure-msg?

#Comment by Bryan (talk | contribs) 18:12, 16 August 2010

Here or some place in the repository?

#Comment by Nikerabbit (talk | contribs) 18:43, 16 August 2010

See Localisation#Adding_new_messages and Localisation#Message_documentation.

#Comment by Bryan (talk | contribs) 14:20, 20 August 2010

Setting fixme so I don't forget.

#Comment by Bryan (talk | contribs) 18:49, 9 October 2010

Thanks demon for fixing.

upload-warning-msg and upload-warning-subj are currently used in code paths that are disabled because they are not implemented. I do not think that I will implement this future soon (i.e. for 1.17 or 1.18 even). Should I remove the messages all together?

Status & tagging log

23:17, 19 September 2010 😂 (talk | contribs) changed the status of r70138 [removed: fixme added: resolved]
14:20, 20 August 2010 Bryan (talk | contribs) changed the status of r70138 [removed: new added: fixme]