r70017 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70016‎ | r70017 | r70018 >
Date:15:49, 27 July 2010
Author:reedy
Status:reverted
Tags:
Comment:
Remove some pre 1.15.999 compatability stuff (1.16 is due to be released, and we're working on 1.17)
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
@@ -108,8 +108,7 @@
109109 }
110110
111111 private static function getRowsObject( $t ) {
112 - // <= 1.15 compatibility, it kinda sucks having to do all this up here.
113 - $tables = array( 'watchlist', 'user_message_state' );
 112+ $tables = array( 'watchlist', 'user_message_state', 'user_properties' );
114113 $joins = array(
115114 'user_message_state' =>
116115 array(
@@ -118,28 +117,17 @@
119118 'ums_user=wl_user',
120119 'ums_thread' => $t->id()
121120 )
122 - )
123 - );
124 - $fields = array( 'wl_user', 'ums_user', 'ums_read_timestamp' );
125 -
126 - global $wgVersion;
127 - if ( version_compare( $wgVersion, '1.15.999', '<=' ) ) {
128 - $oldPrefCompat = true;
129 -
130 - $tables[] = 'user';
131 - $joins['user'] = array( 'left join', 'user_id=wl_user' );
132 - $fields[] = 'user_options';
133 - } else {
134 - $tables[] = 'user_properties';
135 - $joins['user_properties'] = array(
 121+ ),
 122+ 'user_properties' =>
 123+ array(
136124 'left join',
137125 array(
138126 'up_user=wl_user',
139127 'up_property' => 'lqtnotifytalk',
140128 )
141 - );
142 - $fields[] = 'up_value';
143 - }
 129+ )
 130+ );
 131+ $fields = array( 'wl_user', 'ums_user', 'ums_read_timestamp', 'up_value' );
144132
145133 $dbr = wfGetDB( DB_SLAVE );
146134 return $dbr->select( $tables, $fields, self::getWhereClause( $t ), __METHOD__, array(), $joins );

Follow-up revisions

RevisionCommit summaryAuthorDate
r70075Revert r70017 and r70018. I'm not going to deliberately remove support for 1....werdna10:02, 28 July 2010
r81028Remove < 1.16 back compat checks, LQT trunk is RL'd so can't work with these ...reedy16:20, 26 January 2011

Status & tagging log