r70016 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70015‎ | r70016 | r70017 >
Date:15:44, 27 July 2010
Author:reedy
Status:deferred
Tags:
Comment:
Remove some more unused variables
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Thread.php (modified) (history)
  • /trunk/extensions/LiquidThreads/compat/HTMLForm.php (modified) (history)
  • /trunk/extensions/LiquidThreads/pages/TalkpageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/compat/HTMLForm.php
@@ -539,8 +539,6 @@
540540 return wfMsgExt( 'htmlform-int-invalid', 'parse' );
541541 }
542542
543 - $in_range = true;
544 -
545543 if ( isset( $this->mParams['min'] ) ) {
546544 $min = $this->mParams['min'];
547545 if ( $min > $value )
Index: trunk/extensions/LiquidThreads/classes/Thread.php
@@ -255,7 +255,7 @@
256256 $fname = __METHOD__ . "/" . $fname;
257257 }
258258
259 - $res = $dbr->update( 'thread',
 259+ $dbr->update( 'thread',
260260 /* SET */ $this->getRow(),
261261 /* WHERE */ array( 'thread_id' => $this->id, ),
262262 $fname );
Index: trunk/extensions/LiquidThreads/pages/TalkpageView.php
@@ -48,8 +48,6 @@
4949
5050 $article = new Article( $this->title );
5151
52 - $oldid = $this->request->getVal( 'oldid', null );
53 -
5452 wfLoadExtensionMessages( 'LiquidThreads' );
5553 // If $article_text == "", the talkpage was probably just created
5654 // when the first thread was posted to make the links blue.

Status & tagging log