r69985 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69984‎ | r69985 | r69986 >
Date:03:34, 27 July 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r69770, r69771: X-Vary-Options fixes.
Modified paths:
  • /branches/REL1_16/phase3/includes/OutputHandler.php (modified) (history)
  • /branches/REL1_16/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/OutputHandler.php
@@ -90,7 +90,10 @@
9191 }
9292 if ( !$foundVary ) {
9393 header( 'Vary: Accept-Encoding' );
94 - header( 'X-Vary-Options: Accept-Encoding;list-contains=gzip' );
 94+ global $wgUseXVO;
 95+ if ( $wgUseXVO ) {
 96+ header( 'X-Vary-Options: Accept-Encoding;list-contains=gzip' );
 97+ }
9598 }
9699 return $s;
97100 }
Property changes on: branches/REL1_16/phase3/includes/OutputHandler.php
___________________________________________________________________
Added: svn:mergeinfo
98101 Merged /branches/sqlite/includes/OutputHandler.php:r58211-58321
99102 Merged /trunk/phase3/includes/OutputHandler.php:r63549,63764,63897-63901,64876,64881,64948,69770
100103 Merged /branches/wmf-deployment/includes/OutputHandler.php:r53381
101104 Merged /branches/REL1_15/phase3/includes/OutputHandler.php:r51646
Index: branches/REL1_16/phase3/includes/OutputPage.php
@@ -1266,7 +1266,7 @@
12671267 $cvCookies = $this->getCacheVaryCookies();
12681268 foreach ( $cvCookies as $cookieName ) {
12691269 # Check for a simple string match, like the way squid does it
1270 - if ( strpos( $cookieHeader, $cookieName ) ) {
 1270+ if ( strpos( $cookieHeader, $cookieName ) !== false ) {
12711271 wfDebug( __METHOD__.": found $cookieName\n" );
12721272 return true;
12731273 }
Property changes on: branches/REL1_16/phase3/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
12741274 Merged /trunk/phase3/includes/OutputPage.php:r69771

Follow-up revisions

RevisionCommit summaryAuthorDate
r69987Release notes for r69985tstarling07:35, 27 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69770Send XVO headers only if $wgUseXVO is true.tstarling05:00, 23 July 2010
r69771Fixed inappropriate conversion of strpos() result to boolean, causing the fir...tstarling05:11, 23 July 2010

Status & tagging log