r69771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69770‎ | r69771 | r69772 >
Date:05:11, 23 July 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fixed inappropriate conversion of strpos() result to boolean, causing the first cookie in the header to not be recognised as a cache-varying cookie
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1275,7 +1275,7 @@
12761276 $cvCookies = $this->getCacheVaryCookies();
12771277 foreach ( $cvCookies as $cookieName ) {
12781278 # Check for a simple string match, like the way squid does it
1279 - if ( strpos( $cookieHeader, $cookieName ) ) {
 1279+ if ( strpos( $cookieHeader, $cookieName ) !== false ) {
12801280 wfDebug( __METHOD__ . ": found $cookieName\n" );
12811281 return true;
12821282 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r69985MFT r69770, r69771: X-Vary-Options fixes.tstarling03:34, 27 July 2010

Status & tagging log