r69918 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69917‎ | r69918 | r69919 >
Date:21:43, 25 July 2010
Author:platonides
Status:ok
Tags:
Comment:
Kill $wgDBport_db2
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -478,7 +478,7 @@
479479 public function open( $server, $user, $password, $dbName )
480480 {
481481 // Load the port number
482 - global $wgDBport_db2, $wgDBcataloged;
 482+ global $wgDBport, $wgDBcataloged;
483483 wfProfileIn( __METHOD__ );
484484
485485 // Load IBM DB2 driver if missing
@@ -499,7 +499,7 @@
500500 $this->close();
501501 // Cache conn info
502502 $this->mServer = $server;
503 - $this->mPort = $port = $wgDBport_db2;
 503+ $this->mPort = $port = $wgDBport;
504504 $this->mUser = $user;
505505 $this->mPassword = $password;
506506 $this->mDBname = $dbName;
Index: trunk/phase3/config/Installer.php
@@ -1859,7 +1859,7 @@
18601860 } elseif( $conf->DBtype == 'ibm_db2' ) {
18611861 $dbsettings =
18621862 "# DB2 specific settings
1863 -\$wgDBport_db2 = \"{$slconf['DBport_db2']}\";
 1863+\$wgDBport = \"{$slconf['DBport_db2']}\";
18641864 \$wgDBmwschema = \"{$slconf['DBdb2schema']}\";
18651865 \$wgDBcataloged = \"{$slconf['DBcataloged']}\";";
18661866 } elseif( $conf->DBtype == 'oracle' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r69935RELEASE NOTES for r69918platonides09:40, 26 July 2010
r72166Completed removal of $wgDBport_db2 in favour of regular $wgDBport begun by pl...leonsp21:06, 1 September 2010

Status & tagging log