r69919 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69918‎ | r69919 | r69920 >
Date:21:43, 25 July 2010
Author:reedy
Status:ok
Tags:
Comment:
1 more dynamic used as static
Modified paths:
  • /trunk/phase3/languages/LanguageConverter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/LanguageConverter.php
@@ -881,7 +881,6 @@
882882 }
883883 }
884884
885 -
886885 // parse the mappings in this page
887886 $blocks = StringUtils::explode( '-{', $txt );
888887 $ret = array();
@@ -907,7 +906,6 @@
908907 }
909908 $parsed[$key] = true;
910909
911 -
912910 // recursively parse the subpages
913911 if ( $recursive ) {
914912 foreach ( $sublinks as $link ) {
@@ -918,7 +916,7 @@
919917
920918 if ( $this->mUcfirst ) {
921919 foreach ( $ret as $k => $v ) {
922 - $ret[Language::ucfirst( $k )] = Language::ucfirst( $v );
 920+ $ret[$this->mLangObj->ucfirst( $k )] = $this->mLangObj->ucfirst( $v );
923921 }
924922 }
925923 return $ret;

Status & tagging log