r69915 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69914‎ | r69915 | r69916 >
Date:21:25, 25 July 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Add $wgLicenseTerms to DefaultSettings
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -4187,6 +4187,11 @@
41884188 $wgRightsText = null;
41894189 $wgRightsIcon = null;
41904190
 4191+/**
 4192+ * Set to an array of metadata terms. Else they will be loaded based on $wgRightsUrl
 4193+ */
 4194+$wgLicenseTerms = false;
 4195+
41914196 /** Set this to some HTML to override the rights icon with an arbitrary logo */
41924197 $wgCopyrightIcon = null;
41934198

Follow-up revisions

RevisionCommit summaryAuthorDate
r76277MFT r69915platonides22:49, 7 November 2010
r76278MFT r69915platonides22:49, 7 November 2010

Comments

#Comment by Platonides (talk | contribs)   10:55, 28 July 2010

Looking at the risk of injection for $wgLicenseTerms

  • The path is only followed if $wgEnableCreativeCommonsRdf = true; and $wgRightsUrl is set.
  • It can only contain an array of 're','di','de','nc','no','by','sa','sc' so it could at most confuse a bot about the wiki license by poviding a garbled url.
  • WebStart.php protects from the register_globals. so it isn't really exploitable.

Status & tagging log