r69914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69913‎ | r69914 | r69915 >
Date:21:15, 25 July 2010
Author:reedy
Status:ok
Tags:
Comment:
A few more wrong static things

Remove some =& from LanguageKk_cyrl
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/json/Services_JSON.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_Hash.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageKk_cyrl.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/json/Services_JSON.php
@@ -431,7 +431,7 @@
432432 $this->indent--;
433433
434434 foreach($properties as $property) {
435 - if(Services_JSON::isError($property)) {
 435+ if($this->isError($property)) {
436436 return $property;
437437 }
438438 }
@@ -445,7 +445,7 @@
446446 $this->indent--;
447447
448448 foreach($elements as $element) {
449 - if(Services_JSON::isError($element)) {
 449+ if($this->isError($element)) {
450450 return $element;
451451 }
452452 }
@@ -462,7 +462,7 @@
463463 $this->indent--;
464464
465465 foreach($properties as $property) {
466 - if(Services_JSON::isError($property)) {
 466+ if($this->isError($property)) {
467467 return $property;
468468 }
469469 }
@@ -489,7 +489,7 @@
490490 {
491491 $encoded_value = $this->encode2($value);
492492
493 - if(Services_JSON::isError($encoded_value)) {
 493+ if($this->isError($encoded_value)) {
494494 return $encoded_value;
495495 }
496496
Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
@@ -1263,7 +1263,8 @@
12641264 var $numberedExpansionCache, $namedExpansionCache;
12651265
12661266 function __construct( $preprocessor, $parent = false, $numberedArgs = array(), $namedArgs = array(), $title = false ) {
1267 - PPFrame_DOM::__construct( $preprocessor );
 1267+ parent::__construct( $preprocessor );
 1268+
12681269 $this->parent = $parent;
12691270 $this->numberedArgs = $numberedArgs;
12701271 $this->namedArgs = $namedArgs;
@@ -1375,7 +1376,7 @@
13761377 var $args;
13771378
13781379 function __construct( $preprocessor, $args ) {
1379 - PPFrame_DOM::__construct( $preprocessor );
 1380+ parent::__construct( $preprocessor );
13801381 $this->args = $args;
13811382 }
13821383
Index: trunk/phase3/includes/parser/Preprocessor_Hash.php
@@ -1213,7 +1213,8 @@
12141214 var $numberedExpansionCache, $namedExpansionCache;
12151215
12161216 function __construct( $preprocessor, $parent = false, $numberedArgs = array(), $namedArgs = array(), $title = false ) {
1217 - PPFrame_Hash::__construct( $preprocessor );
 1217+ parent::__construct( $preprocessor );
 1218+
12181219 $this->parent = $parent;
12191220 $this->numberedArgs = $numberedArgs;
12201221 $this->namedArgs = $namedArgs;
@@ -1325,7 +1326,7 @@
13261327 var $args;
13271328
13281329 function __construct( $preprocessor, $args ) {
1329 - PPFrame_Hash::__construct( $preprocessor );
 1330+ parent::__construct( $preprocessor );
13301331 $this->args = $args;
13311332 }
13321333
Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -378,7 +378,7 @@
379379 */
380380 function getDescriptionStylesheetUrl() {
381381 if ( $this->scriptDirUrl ) {
382 - return self::makeUrl( 'title=MediaWiki:Filepage.css&' .
 382+ return $this->makeUrl( 'title=MediaWiki:Filepage.css&' .
383383 wfArrayToCGI( Skin::getDynamicStylesheetQuery() ) );
384384 }
385385 }
Index: trunk/phase3/languages/classes/LanguageKk_cyrl.php
@@ -477,9 +477,9 @@
478478 $secondPerson = array( "ز" ); // 1st plural, 2nd formal
479479 $thirdPerson = array( "ى", "ٸ" ); // 3rd
480480
481 - $lastLetter = self::lastLetter( $word, $allVowels );
482 - $wordEnding =& $lastLetter[0];
483 - $wordLastVowel =& $lastLetter[1];
 481+ $lastLetter = $this->lastLetter( $word, $allVowels );
 482+ $wordEnding = $lastLetter[0];
 483+ $wordLastVowel = $lastLetter[1];
484484
485485 // Now convert the word
486486 switch ( $case ) {

Status & tagging log