r69889 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69888‎ | r69889 | r69890 >
Date:18:20, 25 July 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r68354. $wgUser *is* used in successfulLogin() and mailPasswordInternal().
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -803,7 +803,7 @@
804804 * @private
805805 */
806806 function mailPasswordInternal( $u, $throttle = true, $emailTitle = 'passwordremindertitle', $emailText = 'passwordremindertext' ) {
807 - global $wgServer, $wgScript, $wgNewPasswordExpiry;
 807+ global $wgServer, $wgScript, $wgUser, $wgNewPasswordExpiry;
808808
809809 if ( $u->getEmail() == '' ) {
810810 return new WikiError( wfMsg( 'noemail', $u->getName() ) );
@@ -838,7 +838,7 @@
839839 * @private
840840 */
841841 function successfulLogin() {
842 - global $wgOut;
 842+ global $wgUser, $wgOut;
843843
844844 # Run any hooks; display injected HTML if any, else redirect
845845 $injected_html = '';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68354Correct the address of the FSF in some of the GPL headers...hartman13:16, 21 June 2010

Comments

#Comment by Reedy (talk | contribs)   19:11, 25 July 2010

Aye, false positive when it's the variable used by reference. Reported as a bug http://youtrack.jetbrains.net/issue/WI-2634


Did notice the false positive when reviewing some.

Status & tagging log