r69888 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69887‎ | r69888 | r69889 >
Date:18:16, 25 July 2010
Author:platonides
Status:ok
Tags:
Comment:
Do not use a global $action to get the action.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -26,7 +26,7 @@
2727 * Constructor
2828 */
2929 function wfSpecialMovepage( $par = null ) {
30 - global $wgUser, $wgOut, $wgRequest, $action;
 30+ global $wgUser, $wgOut, $wgRequest;
3131
3232 # Check for database lock
3333 if ( wfReadOnly() ) {
@@ -61,7 +61,7 @@
6262
6363 $form = new MovePageForm( $oldTitle, $newTitle );
6464
65 - if ( 'submit' == $action && $wgRequest->wasPosted()
 65+ if ( 'submit' == $wgRequest->getVal( 'action' ) && $wgRequest->wasPosted()
6666 && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
6767 $form->doSubmit();
6868 } else {

Status & tagging log