r69875 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69874‎ | r69875 | r69876 >
Date:16:59, 25 July 2010
Author:philip
Status:ok (Comments)
Tags:
Comment:
follow up r69874. use string instead of object .
Modified paths:
  • /trunk/phase3/includes/parser/LinkHolderArray.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/LinkHolderArray.php
——@@ -316,7 +316,7 @@
317317 );
318318 // separate titles with \0 because it would never appears
319319 // in a valid title
320 - $titlesToBeConverted .= $title . '\0';
 320+ $titlesToBeConverted .= $titleText . '\0';
321321 }
322322 }
323323 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69874Performance improvement: in doVariants(), concatenate a bulk of titles to a s...philip16:53, 25 July 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   01:51, 16 December 2010

This was updated in r69949

Status & tagging log