r69949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69948‎ | r69949 | r69950 >
Date:16:09, 26 July 2010
Author:philip
Status:ok (Comments)
Tags:
Comment:
Follow up r69874. Fix the separation markup.
Modified paths:
  • /trunk/phase3/includes/parser/LinkHolderArray.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/LinkHolderArray.php
@@ -316,7 +316,7 @@
317317 );
318318 // separate titles with \0 because it would never appears
319319 // in a valid title
320 - $titlesToBeConverted .= $titleText . '\0';
 320+ $titlesToBeConverted .= $titleText . "\0";
321321 }
322322 }
323323 }
@@ -325,7 +325,7 @@
326326 $titlesAllVariants = $wgContLang->convertLinkToAllVariants( $titlesToBeConverted );
327327 $allVariantsName = array_keys( $titlesAllVariants );
328328 foreach ( $titlesAllVariants as &$titlesVariant ) {
329 - $titlesVariant = explode( '\0', $titlesVariant );
 329+ $titlesVariant = explode( "\0", $titlesVariant );
330330 }
331331
332332 // Then add variants of links to link batch

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69874Performance improvement: in doVariants(), concatenate a bulk of titles to a s...philip16:53, 25 July 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   01:41, 16 December 2010

Makes total sense to me!

Status & tagging log