r69755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69754‎ | r69755 | r69756 >
Date:21:52, 22 July 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
LIMIT_SML2, LIMIT_BIG2 are in ApiBase, not ApiMain
Modified paths:
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiUpload.php
——@@ -270,7 +270,9 @@
271271 $this->verifyUpload();
272272
273273 $warnings = $this->checkForWarnings();
274 - if ( isset( $warnings ) ) return $warnings;
 274+ if ( isset( $warnings ) ) {
 275+ return $warnings;
 276+ }
275277
276278 // Use comment as initial page text by default
277279 if ( is_null( $this->mParams['text'] ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r69756Fix fail from r69755, press save, actually do "LIMIT_SML2, LIMIT_BIG2 are in ...reedy21:54, 22 July 2010
r69777Stylize API up to date...reedy07:33, 23 July 2010

Comments

#Comment by Catrope (talk | contribs)   07:18, 23 July 2010 
-		if ( isset( $warnings ) ) return $warnings;
+		if ( isset( $warnings ) ) {
+            return $warnings;
+        }

The last two lines are indented with spaces instead of tabs.

#Comment by 😂 (talk | contribs)   19:13, 24 September 2010

Was fixed in r69777.

Status & tagging log