r69754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69753‎ | r69754 | r69755 >
Date:21:44, 22 July 2010
Author:reedy
Status:ok
Tags:
Comment:
$this isn't valid in a static function. Fix for r46507

Return error wrapped in array as per rest of code
Modified paths:
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiDelete.php
@@ -143,7 +143,7 @@
144144
145145 $error = '';
146146 if ( !wfRunHooks( 'ArticleDelete', array( &$article, &$wgUser, &$reason, $error ) ) ) {
147 - $this->dieUsageMsg( array( 'hookaborted', $error ) );
 147+ return array( array( 'hookaborted', $error ) );
148148 }
149149
150150 // Luckily, Article.php provides a reusable delete function that does the hard work for us

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46507Fix broken calls to ArticleDelete hook.werdna01:04, 29 January 2009

Status & tagging log