r69553 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69552‎ | r69553 | r69554 >
Date:15:13, 19 July 2010
Author:catrope
Status:deferred
Tags:
Comment:
Followup to r69546: defer sending of notification by 15 minutes
Modified paths:
  • /trunk/phase3/maintenance/addwiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/addwiki.php
@@ -149,16 +149,15 @@
150150 # Rebuild interwiki tables
151151 # passthru( '/home/wikipedia/conf/interwiki/update' );
152152
153 - $user = getenv( 'USER' );
154153 $time = wfTimestamp( TS_RFC2822 );
155 - UserMailer::send( new MailAddress( 'newprojects@list.wikimedia.org' ),
156 - new MailAddress( $wgPasswordSender ), "New wiki: $dbName",
157 - <<<EOT
158 -A new wiki was created by $user at $time for a $ucsite in $name ($lang).
159 -Once the wiki is fully set up, it'll be visible at http://$domain
160 -EOT;
161 - );
162 -
 154+ $escDbName = wfEscapeShellArg( $dbname );
 155+ $escTime = wfEscapeShellArg( $time );
 156+ $escUcsite = wfEscapeShellArg( $ucsite );
 157+ $escName = wfEscapeShellArg( $name );
 158+ $escLang = wfEscapeShellArg( $lang );
 159+ $escDomain = wfEscapeShellArg( $domain );
 160+ shell_exec( "echo notifyNewProjects $escDbName $escTime $escUcsite $escName $escLang $escDomain | at now + 15 minutes" );
 161+
163162 $this->output( "Script ended. You still have to:
164163 * Add any required settings in InitialiseSettings.php
165164 * Run sync-common-all

Follow-up revisions

RevisionCommit summaryAuthorDate
r69608Followup to r69553: double-escape arguments because we're feeding them to a s...catrope13:11, 20 July 2010
r696191.16wmf4: Merge addwiki.php tweaks from trunk: r69546, r69553, r69554, r69608...catrope15:04, 20 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69546(bug 24398) Make addwiki.php send a notification e-mail to newprojects@lists....catrope14:00, 19 July 2010

Status & tagging log