r69552 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69551‎ | r69552 | r69553 >
Date:15:00, 19 July 2010
Author:adam
Status:ok
Tags:
Comment:
Followup to r68750. removing redundancy
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.preview.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.preview.css
@@ -14,26 +14,10 @@
1515 padding: 1em;
1616 background-color: white;
1717 }
18 -
1918 #wikiEditor-0-preview-dialog .wikiEditor-ui-loading {
20 - background: #f3f3f3;
21 - z-index: 10;
22 - position: absolute;
23 - left: 0;
24 - text-align: center;
25 - height: 100%;
26 - width: 100%;
2719 overflow: hidden;
2820 border: none;
2921 }
30 -#wikiEditor-0-preview-dialog .wikiEditor-ui-loading span {
31 - display: block;
32 - height: 24px;
33 - width: 24px;
34 - background: url( ../images/wikiEditor/toolbar/loading.gif ) 0 0 no-repeat;
35 - text-indent: -9999px;
36 - margin: 0 auto;
37 -}
3822 .ui-dialog .ui-dialog-buttonpane {
3923 margin: 0 !important;
4024 }
\ No newline at end of file
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -1220,26 +1220,10 @@
12211221 padding: 1em;
12221222 background-color: white;
12231223 }
1224 -
12251224 #wikiEditor-0-preview-dialog .wikiEditor-ui-loading {
1226 - background: #f3f3f3;
1227 - z-index: 10;
1228 - position: absolute;
1229 - left: 0;
1230 - text-align: center;
1231 - height: 100%;
1232 - width: 100%;
12331225 overflow: hidden;
12341226 border: none;
12351227 }
1236 -#wikiEditor-0-preview-dialog .wikiEditor-ui-loading span {
1237 - display: block;
1238 - height: 24px;
1239 - width: 24px;
1240 - background: url( ../images/wikiEditor/toolbar/loading.gif ) 0 0 no-repeat;
1241 - text-indent: -9999px;
1242 - margin: 0 auto;
1243 -}
12441228 .ui-dialog .ui-dialog-buttonpane {
12451229 margin: 0 !important;
12461230 }
\ No newline at end of file
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -1154,24 +1154,9 @@
11551155 background-color:white;
11561156 }
11571157 #wikiEditor-0-preview-dialog .wikiEditor-ui-loading{
1158 -background:#f3f3f3;
1159 -z-index:10;
1160 -position:absolute;
1161 -left:0;
1162 -text-align:center;
1163 -height:100%;
1164 -width:100%;
11651158 overflow:hidden;
11661159 border:none;
11671160 }
1168 -#wikiEditor-0-preview-dialog .wikiEditor-ui-loading span{
1169 -display:block;
1170 -height:24px;
1171 -width:24px;
1172 -background:url( ../images/wikiEditor/toolbar/loading.gif ) 0 0 no-repeat;
1173 -text-indent:-9999px;
1174 -margin:0 auto;
1175 -}
11761161 .ui-dialog .ui-dialog-buttonpane{
11771162 margin:0 !important;
11781163 }
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -24,18 +24,18 @@
2525 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 2 ),
2626 array( 'src' => 'css/wikiEditor.css', 'version' => 14 ),
2727 array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 30 ),
28 - array( 'src' => 'css/wikiEditor.preview.css', 'version' => 2 ),
 28+ array( 'src' => 'css/wikiEditor.preview.css', 'version' => 3 ),
2929 array( 'src' => 'css/wikiEditor.previewDialog.css', 'version' => 1 ),
3030 array( 'src' => 'css/wikiEditor.toc.css', 'version' => 31 ),
3131 array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 19 ),
3232 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3333 ),
3434 'combined' => array(
35 - array( 'src' => 'css/combined.css', 'version' => 116 ),
 35+ array( 'src' => 'css/combined.css', 'version' => 117 ),
3636 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3737 ),
3838 'minified' => array(
39 - array( 'src' => 'css/combined.min.css', 'version' => 116 ),
 39+ array( 'src' => 'css/combined.min.css', 'version' => 117 ),
4040 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
4141 ),
4242 )
@@ -86,7 +86,7 @@
8787 array( 'src' => 'js/plugins.combined.js', 'version' => 452 ),
8888 ),
8989 'minified' => array(
90 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 467 ),
 90+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 468 ),
9191 ),
9292 ),
9393 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68750PreviewDialog - styling the loading indicatoradam22:36, 29 June 2010

Status & tagging log