r68750 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r68749‎ | r68750 | r68751 >
Date:22:36, 29 June 2010
Author:adam
Status:resolved (Comments)
Tags:
Comment:
PreviewDialog - styling the loading indicator
Modified paths:
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.preview.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.preview.css
——@@ -14,3 +14,26 @@
1515 padding: 1em;
1616 background-color: white;
1717 }
 18+
 19+#wikiEditor-0-preview-dialog .wikiEditor-ui-loading {
 20+ background: #f3f3f3;
 21+ z-index: 10;
 22+ position: absolute;
 23+ left: 0;
 24+ text-align: center;
 25+ height: 100%;
 26+ width: 100%;
 27+ overflow: hidden;
 28+ border: none;
 29+}
 30+#wikiEditor-0-preview-dialog .wikiEditor-ui-loading span {
 31+ display: block;
 32+ height: 24px;
 33+ width: 24px;
 34+ background: url( ../images/wikiEditor/toolbar/loading.gif ) 0 0 no-repeat;
 35+ text-indent: -9999px;
 36+ margin: 0 auto;
 37+}
 38+.ui-dialog .ui-dialog-buttonpane {
 39+ margin: 0 !important;
 40+}
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r68751Recombining for r68750adam22:39, 29 June 2010
r69552Followup to r68750. removing redundancyadam15:00, 19 July 2010

Comments

#Comment by Catrope (talk | contribs)   13:40, 19 July 2010 
+#wikiEditor-0-preview-dialog .wikiEditor-ui-loading {
+	background: #f3f3f3;
+	z-index: 10;
+	position: absolute;
+	left: 0;
+	text-align: center;
+	height: 100%;
+	width: 100%;
+	overflow: hidden;
+	border: none;
+}
+#wikiEditor-0-preview-dialog .wikiEditor-ui-loading span {
+	display: block;
+	height: 24px;
+	width: 24px;
+	background: url( ../images/wikiEditor/toolbar/loading.gif ) 0 0 no-repeat;
+	text-indent: -9999px;
+	margin: 0 auto;
+}

A lot of these rules are redundant. The following are already defined for the general .wikiEditor-ui-loading case in wikiEditor.css: 

.wikiEditor-ui-loading {
	background: #f3f3f3;
	z-index: 10;
	position: absolute;
	top: 0;
	left: 0;
	text-align: center;
	height: 100%;
	width: 100%;
	border: 1px solid silver;
	margin: -1px;
}
.wikiEditor-ui-loading span {
	display: block;
	height: 24px;
	width: 24px;
	background: url( ../images/wikiEditor/toolbar/loading.gif ) 0 0 no-repeat;
	text-indent: -9999px;
	margin: 0 auto;
}

Status & tagging log