r69347 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69346‎ | r69347 | r69348 >
Date:21:00, 14 July 2010
Author:mah
Status:resolved (Comments)
Tags:
Comment:
follow up r69339: Add a missing setVaryCookie for consistency and to avoid user X with skin Y getting the response marked up for skin B.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
——@@ -284,6 +284,7 @@
285285
286286 if ( $this->fld_parsedcomment ) {
287287 global $wgUser;
 288+ $this->getMain()->setVaryCookie();
288289 $vals['parsedcomment'] = $wgUser->getSkin()->formatComment( $row->log_comment, $title );
289290 }
290291 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r693801.16wmf4: MFT r69347, r69350, r69369, r69379catrope09:41, 15 July 2010
r69932* MFT r69776, and followups r69784, r69928, r69931, and superseded base revis...tstarling08:03, 26 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69339API: Make output containing private or user-specific data uncacheable for log...catrope19:00, 14 July 2010

Comments

#Comment by Tim Starling (talk | contribs)   02:33, 20 July 2010

This gives different vary headers for different URLs, so it won't work properly.

Roan: see how easy it is to screw up? This is why I want to keep setVaryCookie() calls to a minimum.

Status & tagging log