r69931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69930‎ | r69931 | r69932 >
Date:07:35, 26 July 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r69776: remove unused variable ApiMain::$mVaryCookie
Modified paths:
  • /trunk/phase3/includes/api/ApiMain.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMain.php
@@ -124,7 +124,7 @@
125125
126126 private $mPrinter, $mModules, $mModuleNames, $mFormats, $mFormatNames;
127127 private $mResult, $mAction, $mShowVersions, $mEnableWrite, $mRequest;
128 - private $mInternalMode, $mSquidMaxage, $mModule, $mVaryCookie;
 128+ private $mInternalMode, $mSquidMaxage, $mModule;
129129
130130 private $mCacheMode = 'private';
131131 private $mCacheControl = array();
@@ -170,7 +170,6 @@
171171
172172 $this->mSquidMaxage = - 1; // flag for executeActionWithErrorHandling()
173173 $this->mCommit = false;
174 - $this->mVaryCookie = false;
175174 }
176175
177176 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r69932* MFT r69776, and followups r69784, r69928, r69931, and superseded base revis...tstarling08:03, 26 July 2010
r70061Brought the API cache header handling into sync with the REL1_16 branch, by r...tstarling02:01, 28 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69776Rewrote r69339 etc. to clean up API cache header handling....tstarling07:17, 23 July 2010

Status & tagging log