r69332 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69331‎ | r69332 | r69333 >
Date:17:28, 14 July 2010
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Revert r64217 (WikiSysop is back, and now (s)he's localisable) per comments on review
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -308,7 +308,6 @@
309309 Traditionally, this prefix is derived from the name of the wiki, but it cannot contain punctuation characters such as "#" or ":".',
310310 'config-ns-invalid' => 'The specified namespace "<nowiki>$1</nowiki>" is invalid.
311311 Specify a different project namespace',
312 - 'config-admin-default-username' => 'WikiSysop',
313312 'config-admin-box' => 'Administrator account',
314313 'config-admin-name' => 'Your name:',
315314 'config-admin-password' => 'Password:',
@@ -669,7 +668,6 @@
670669 Dit voorvoegsel wordt meestal afgeleid van de naam van de wiki, maar het kan geen bijzondere tekens bevatten als \"#\" of \":\".",
671670 'config-ns-invalid' => 'De aangegeven naamruimte "<nowiki>$1</nowiki>" is ongeldig.
672671 Geef een andere naamruimte op.',
673 - 'config-admin-default-username' => 'WikiBeheerder',
674672 'config-admin-box' => 'Beheerdersaccount',
675673 'config-admin-name' => 'Uw naam:',
676674 'config-admin-password' => 'Wachtwoord:',
@@ -777,5 +775,4 @@
778776 $messages['ru'] = array(
779777 'config-title' => 'Установка MediaWiki $1',
780778 'config-page-language' => 'Язык',
781 - 'config-admin-default-username' => 'ВикиАдминистратор',
782779 );
Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -930,10 +930,6 @@
931931 }
932932 if ( isset( $languages[$contLang] ) ) {
933933 $this->setVar( 'wgLanguageCode', $contLang );
934 - if ( $this->getVar( '_AdminName' ) === null ) {
935 - // Load localised sysop username in *content* language
936 - $this->setVar( '_AdminName', wfMsgForContent( 'config-admin-default-username' ) );
937 - }
938934 }
939935 return 'continue';
940936 }
Index: trunk/phase3/includes/installer/Installer.php
@@ -59,7 +59,7 @@
6060 '_SameAccount' => true,
6161 '_CreateDBAccount' => false,
6262 '_NamespaceType' => 'site-name',
63 - '_AdminName' => null, // will be set later, when the user selects language
 63+ '_AdminName' => '', // will be set later, when the user selects language
6464 '_AdminPassword' => '',
6565 '_AdminPassword2' => '',
6666 '_AdminEmail' => '',

Follow-up revisions

RevisionCommit summaryAuthorDate
r69518* re r69332, r64217: complete removal of WikiSysop for CLI installer...mah18:52, 18 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64217WikiSysop is back, and now (s)he's localisable!maxsem17:51, 26 March 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   18:43, 18 July 2010

When removing a localization like this, please grep the code to see where else it is used. This broke the CLI installer because you didn't remove it there.

Status & tagging log