r64217 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64216‎ | r64217 | r64218 >
Date:17:51, 26 March 2010
Author:maxsem
Status:reverted (Comments)
Tags:
Comment:
WikiSysop is back, and now (s)he's localisable!
Modified paths:
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/new-installer/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/new-installer/phase3/languages/messages/MessagesRu.php (modified) (history)
  • /branches/new-installer/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/maintenance/language/messages.inc
@@ -3285,6 +3285,7 @@
32863286 'config-ns-other',
32873287 'config-project-namespace-help',
32883288 'config-ns-invalid',
 3289+ 'config-admin-default-username',
32893290 'config-admin-box',
32903291 'config-admin-name',
32913292 'config-admin-password',
Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -853,6 +853,10 @@
854854 }
855855 if ( isset( $languages[$contLang] ) ) {
856856 $this->setVar( 'wgLanguageCode', $contLang );
 857+ if ( $this->getVar( '_AdminName' ) === null ) {
 858+ // Load localised sysop username in *content* language
 859+ $this->setVar( '_AdminName', wfMsgReal( 'config-admin-default-username', array(), false, $contLang ) );
 860+ }
857861 }
858862 return 'continue';
859863 }
Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -59,7 +59,7 @@
6060 '_SameAccount' => true,
6161 '_CreateDBAccount' => false,
6262 '_NamespaceType' => 'site-name',
63 - '_AdminName' => '',
 63+ '_AdminName' => null, // will be set later, when the user selects language
6464 '_AdminPassword' => '',
6565 '_AdminPassword2' => '',
6666 '_AdminEmail' => '',
Index: branches/new-installer/phase3/languages/messages/MessagesRu.php
@@ -3344,6 +3344,10 @@
33453345 'unknown_extension_tag' => 'Неизвестный тег дополнения «$1»',
33463346 'duplicate-defaultsort' => 'Внимание. Ключ сортировки по умолчанию «$2» переопределяет прежний ключ сортировки по умолчанию «$1».',
33473347
 3348+# Installer
 3349+
 3350+'config-admin-default-username' => 'ВикиАдминистратор',
 3351+
33483352 # Special:Version
33493353 'version' => 'Версия MediaWiki',
33503354 'version-extensions' => 'Установленные расширения',
Index: branches/new-installer/phase3/languages/messages/MessagesEn.php
@@ -4348,6 +4348,7 @@
43494349 All page titles in this namespace start with a certain prefix, which you can specify here.
43504350 Traditionally, this prefix is derived from the name of the wiki, but it cannot contain punctuation characters such as # or :',
43514351 'config-ns-invalid' => 'The specified namespace "<nowiki>$1</nowiki>" is invalid. Please specify a different project namespace',
 4352+'config-admin-default-username' => 'WikiSysop',
43524353 'config-admin-box' => 'Administrator account',
43534354 'config-admin-name' => 'Your name:',
43544355 'config-admin-password' => 'Password:',

Follow-up revisions

RevisionCommit summaryAuthorDate
r69332Revert r64217 (WikiSysop is back, and now (s)he's localisable) per comments o...demon17:28, 14 July 2010
r69518* re r69332, r64217: complete removal of WikiSysop for CLI installer...mah18:52, 18 July 2010

Comments

#Comment by Tim Starling (talk | contribs)   00:39, 30 June 2010

Removing the default from the admin username was the number 1 feature request I received from Angela when I asked her what she wanted from the new installer. The issue is that it makes the creator of the wiki anonymous and unidentifiable, and thus difficult to contact. Do you have some really good reason for wanting it back?

#Comment by 😂 (talk | contribs)   17:28, 14 July 2010

No. Reverted this.

Status & tagging log